From 207d2dd10cf54f79770e370304f1e9fefc01f31a Mon Sep 17 00:00:00 2001 From: Shea Levy Date: Wed, 21 Jun 2017 14:51:03 -0400 Subject: [PATCH] GithubStatus: Don't send a pending status for already-finished builds Fixes #488 --- src/lib/Hydra/Plugin/GithubStatus.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/Hydra/Plugin/GithubStatus.pm b/src/lib/Hydra/Plugin/GithubStatus.pm index 35b53472..355e7010 100644 --- a/src/lib/Hydra/Plugin/GithubStatus.pm +++ b/src/lib/Hydra/Plugin/GithubStatus.pm @@ -32,6 +32,8 @@ sub common { foreach my $conf (@config) { next unless $jobName =~ /^$conf->{jobs}$/; + # Don't send out "pending" status updates if the build is already finished + next if !$finished && $b->finished == 1; my $contextTrailer = $conf->{excludeBuildFromContext} ? "" : (":" . $b->id); my $body = encode_json(