From 2156e406b4947a3fbf0128b6b4faf8d9a831f0ce Mon Sep 17 00:00:00 2001
From: Eelco Dolstra <e.dolstra@tudelft.nl>
Date: Fri, 28 Nov 2008 11:00:55 +0000
Subject: [PATCH] * Monitor for dead builds all the time.

---
 src/Hydra/programs/Runner.pl | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/src/Hydra/programs/Runner.pl b/src/Hydra/programs/Runner.pl
index f20e909b..4a5b4a87 100644
--- a/src/Hydra/programs/Runner.pl
+++ b/src/Hydra/programs/Runner.pl
@@ -11,20 +11,22 @@ my $db = Hydra::Schema->connect("dbi:SQLite:dbname=hydra.sqlite", "", "", {});
 $db->storage->dbh->do("PRAGMA synchronous = OFF;");
 
 
-# Unlock jobs whose building process has died.
-$db->txn_do(sub {
-    my @jobs = $db->resultset('Builds')->search(
-        {finished => 0, busy => 1}, {join => 'schedulingInfo'});
-    foreach my $job (@jobs) {
-        my $pid = $job->schedulingInfo->locker;
-        if (kill(0, $pid) != 1) { # see if we can signal the process
-            print "job ", $job->id, " pid $pid died, unlocking\n";
-            $job->schedulingInfo->busy(0);
-            $job->schedulingInfo->locker("");
-            $job->schedulingInfo->update;
+sub unlockDeadJobs {
+    # Unlock jobs whose building process has died.
+    $db->txn_do(sub {
+        my @jobs = $db->resultset('Builds')->search(
+            {finished => 0, busy => 1}, {join => 'schedulingInfo'});
+        foreach my $job (@jobs) {
+            my $pid = $job->schedulingInfo->locker;
+            if (kill(0, $pid) != 1) { # see if we can signal the process
+                print "job ", $job->id, " pid $pid died, unlocking\n";
+                $job->schedulingInfo->busy(0);
+                $job->schedulingInfo->locker("");
+                $job->schedulingInfo->update;
+            }
         }
-    }
-});
+    });
+}
 
 
 sub checkJobs {
@@ -112,6 +114,7 @@ sub checkJobs {
 
 while (1) {
     eval {
+        unlockDeadJobs;
         checkJobs;
     };
     warn $@ if $@;