From a727643286b32ca23fe4a663ea4c60ad4704b7a4 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Tue, 22 Mar 2016 13:10:37 +0100 Subject: [PATCH] inNixShell considered harmful --- release.nix | 9 ++++----- shell.nix | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/release.nix b/release.nix index 37e48060..fddd631c 100644 --- a/release.nix +++ b/release.nix @@ -1,5 +1,6 @@ { hydraSrc ? { outPath = ./.; revCount = 1234; rev = "abcdef"; } , officialRelease ? false +, shell ? false }: with import ; @@ -111,7 +112,7 @@ rec { releaseTools.nixBuild { name = "hydra"; - src = if lib.inNixShell then null else hydraSrc; + src = if shell then null else hydraSrc; buildInputs = [ makeWrapper autoconf automake libtool unzip nukeReferences pkgconfig sqlite libpqxx @@ -130,11 +131,9 @@ rec { gzip bzip2 lzma gnutar unzip git gitAndTools.topGit mercurial darcs gnused bazaar ] ++ lib.optionals stdenv.isLinux [ rpm dpkg cdrkit ] ); - postUnpack = '' + postUnpack = optionalString (!shell) '' # Clean up when building from a working tree. - if [ -z "$IN_NIX_SHELL" ]; then - (cd $sourceRoot && (git ls-files -o --directory | xargs -r rm -rfv)) || true - fi + (cd $sourceRoot && (git ls-files -o --directory | xargs -r rm -rfv)) || true ''; configureFlags = [ "--with-docbook-xsl=${docbook_xsl}/xml/xsl/docbook" ]; diff --git a/shell.nix b/shell.nix index 674b0a10..454c00bf 100644 --- a/shell.nix +++ b/shell.nix @@ -1 +1 @@ -(import ./release.nix {}).build.x86_64-linux +(import ./release.nix { shell = true; }).build.x86_64-linux