NixOS/nix
NixOS/nix
1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2024-09-19 23:03:53 -04:00
Code Activity
nix/tests/functional/local-overlay-store/bad-uris.sh

27 lines
791 B
Bash
Raw Normal View History

Begin to split up overlay-local-store tests The bad-uris tests are now in their own file. "Outer" is a bad name, but it will be split up next.
2023-05-15 15:34:57 -04:00
source common.sh
tests: simplify initialisation and wiring pararameterisation is not actually needed the way things are currently set up, and it confused me when trying to understand what the code does. all but one test sources vars-and-functions.sh, which nominally only defines variables, but in practice is always coupled with the actual initialisation. while the cleaner way of making this more legible would be to source variables and initialisation separately, this would produce a huge diff. the change requires a few small fixes to keep the tests working: - only create test home directory during initialisation that vars-and-functions.sh wrote to the file system seems not write - fix creation of the test directory due to statefulness, the test home directory was implicitly creating the test root, too. decoupling that made it apparent that this was probably not intentional, and certainly confusing. - only source vars-and-functions.sh if init.sh is not needed there is one test case that only needs a helper function but no initialisation side effects - remove some unnecessary cleanups and split parts of re-used test code there were confusing bits in how initialisation code was repurposed, which break if trying to refactor the outer layers naively...
2024-05-06 09:42:49 -04:00
source ../common/init.sh
Begin to split up overlay-local-store tests The bad-uris tests are now in their own file. "Outer" is a bad name, but it will be split up next.
2023-05-15 15:34:57 -04:00
requireEnvironment
setupConfig
local-overlay store tests: `storeDirs` -> `setupStoreDirs` Co-Authored-By: Théophane Hufschmitt <theophane.hufschmitt@tweag.io>
2023-12-11 13:30:40 -05:00
setupStoreDirs
Begin to split up overlay-local-store tests The bad-uris tests are now in their own file. "Outer" is a bad name, but it will be split up next.
2023-05-15 15:34:57 -04:00
mkdir -p $TEST_ROOT/bad_test
badTestRoot=$TEST_ROOT/bad_test
Use `local-overlay://` not `local-overlay` for store URL This is a bit uglier, but allows us to avoid an ad-hoc special case in `store-api.cc`.
2023-10-25 15:29:11 -04:00
storeBadRoot="local-overlay://?root=$badTestRoot&lower-store=$storeA&upper-layer=$storeBTop"
storeBadLower="local-overlay://?root=$storeBRoot&lower-store=$badTestRoot&upper-layer=$storeBTop"
storeBadUpper="local-overlay://?root=$storeBRoot&lower-store=$storeA&upper-layer=$badTestRoot"
Begin to split up overlay-local-store tests The bad-uris tests are now in their own file. "Outer" is a bad name, but it will be split up next.
2023-05-15 15:34:57 -04:00
declare -a storesBad=(
"$storeBadRoot" "$storeBadLower" "$storeBadUpper"
)
for i in "${storesBad[@]}"; do
echo $i
unshare --mount --map-root-user bash <<EOF
source common.sh
local-overlay store tests: `storeDirs` -> `setupStoreDirs` Co-Authored-By: Théophane Hufschmitt <theophane.hufschmitt@tweag.io>
2023-12-11 13:30:40 -05:00
setupStoreDirs
Begin to split up overlay-local-store tests The bad-uris tests are now in their own file. "Outer" is a bad name, but it will be split up next.
2023-05-15 15:34:57 -04:00
mountOverlayfs
expectStderr 1 nix doctor --store "$i" | grepQuiet "overlay filesystem .* mounted incorrectly"
EOF
done
Copy permalink