From 0f18dc54797a1850bc1b91673790ad73e8f4b82f Mon Sep 17 00:00:00 2001 From: Daiderd Jordan Date: Sun, 2 Sep 2018 01:01:23 +0200 Subject: [PATCH] nix doctor: add warning for multiple versions It's pretty easy to unintentionally install a second version of nix into the user profile when using a daemon install. In this case it looks like nix was upgraded while the nix-daemon is probably still unning an older version. --- src/nix/doctor.cc | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/nix/doctor.cc b/src/nix/doctor.cc index a31df595d..6265e9cfe 100644 --- a/src/nix/doctor.cc +++ b/src/nix/doctor.cc @@ -33,9 +33,26 @@ struct CmdDoctor : StoreCommand std::cout << "Store uri: " << store->getUri() << std::endl; std::cout << std::endl; + checkNixInPath(); checkStoreProtocol(store->getProtocol()); } + void checkNixInPath() { + PathSet dirs; + + for (auto & dir : tokenizeString(getEnv("PATH"), ":")) + if (pathExists(dir + "/nix-env")) + dirs.insert(dirOf(canonPath(dir + "/nix-env", true))); + + if (dirs.size() != 1) { + std::cout << "Warning: multiple versions of nix found in PATH." << std::endl; + std::cout << std::endl; + for (auto & dir : dirs) + std::cout << " " << dir << std::endl; + std::cout << std::endl; + } + } + void checkStoreProtocol(unsigned int storeProto) { auto clientProto = GET_PROTOCOL_MAJOR(SERVE_PROTOCOL_VERSION) == GET_PROTOCOL_MAJOR(storeProto) ? SERVE_PROTOCOL_VERSION