NixOS/nix
NixOS/nix
1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2024-09-19 23:03:53 -04:00
Code Activity

Merge pull request #10074 from lf-/jade/ban-implicit-fallthrough

Browse source 
Warn on implicit switch case fallthrough
This commit is contained in:
Théophane Hufschmitt 2024-02-26 10:48:07 +01:00 committed by GitHub
parent 7d9ae5fd06 a82aeedb5b
commit 21282c3c20
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Makefile
View file

@ -81,7 +81,7 @@ ifdef HOST_WINDOWS
GLOBAL_LDFLAGS += -Wl,--export-all-symbols GLOBAL_LDFLAGS += -Wl,--export-all-symbols
endif endif
GLOBAL_CXXFLAGS += -g -Wall -include $(buildprefix)config.h -std=c++2a -I src GLOBAL_CXXFLAGS += -g -Wall -Wimplicit-fallthrough -include $(buildprefix)config.h -std=c++2a -I src
# Include the main lib, causing rules to be defined # Include the main lib, causing rules to be defined

3
src/libexpr/lexer.l
View file

@ -94,6 +94,9 @@ static StringToken unescapeStr(SymbolTable & symbols, char * s, size_t length)
} }
// yacc generates code that uses unannotated fallthrough.
#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
#define YY_USER_INIT initLoc(yylloc) #define YY_USER_INIT initLoc(yylloc)
#define YY_USER_ACTION adjustLoc(yylloc, yytext, yyleng); #define YY_USER_ACTION adjustLoc(yylloc, yytext, yyleng);

2
src/libutil/fs-sink.cc
View file

@ -15,6 +15,7 @@ void copyRecursive(
case SourceAccessor::tSymlink: case SourceAccessor::tSymlink:
{ {
sink.createSymlink(to, accessor.readLink(from)); sink.createSymlink(to, accessor.readLink(from));
break;
} }
case SourceAccessor::tRegular: case SourceAccessor::tRegular:
@ -38,6 +39,7 @@ void copyRecursive(
sink, to + "/" + name); sink, to + "/" + name);
break; break;
} }
break;
} }
case SourceAccessor::tMisc: case SourceAccessor::tMisc: