NixOS/nix
NixOS/nix
1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2024-09-20 11:11:03 -04:00
Code Activity

builtins.exec: Make the argument just a list

Browse source
This commit is contained in:
Shea Levy 2017-03-31 11:58:41 -04:00
parent d299bd710a
commit 3ecb09a40a
1 changed files with 10 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/libexpr/primops.cc
View file

@ -181,30 +181,17 @@ static void prim_importNative(EvalState & state, const Pos & pos, Value * * args
/* Execute a program and parse its output */ /* Execute a program and parse its output */
static void prim_exec(EvalState & state, const Pos & pos, Value * * args, Value & v) static void prim_exec(EvalState & state, const Pos & pos, Value * * args, Value & v)
{ {
state.forceAttrs(*args[0], pos); state.forceList(*args[0], pos);
auto sProgram = state.symbols.create("program"); auto elems = args[0]->listElems();
auto sArguments = state.symbols.create("arguments"); auto count = args[0]->listSize();
if (count == 0) {
throw EvalError(format("at least one argument to 'exec' required, at %1%") % pos);
}
PathSet context; PathSet context;
string program; auto program = state.coerceToString(pos, *elems[0], context, false, false);
bool programSet = false;
Strings commandArgs; Strings commandArgs;
for (auto & attr : *args[0]->attrs) { for (unsigned int i = 1; i < args[0]->listSize(); ++i) {
if (attr.name == sProgram) { commandArgs.emplace_back(state.coerceToString(pos, *elems[i], context, false, false));
program = state.coerceToString(*attr.pos, *attr.value, context, false, false);
programSet = true;
} else if (attr.name == sArguments) {
state.forceList(*attr.value, *attr.pos);
auto elems = attr.value->listElems();
for (unsigned int i = 0; i < attr.value->listSize(); ++i) {
commandArgs.emplace_back(state.coerceToString(*attr.pos, *elems[i], context, false, false));
}
} else {
throw EvalError(format("unexpected attribute ‘%1%’ in argument to builtins.exec, at %2%")
% attr.name % pos);
}
}
if (!programSet) {
throw EvalError(format("attribute ‘programSet’ required, at %1%") % pos);
} }
try { try {
state.realiseContext(context); state.realiseContext(context);