From a353a99269a88bdf1f96a2512c2102b965b5f531 Mon Sep 17 00:00:00 2001
From: Philipp Otterbein <potterbein@blockstream.com>
Date: Tue, 8 Oct 2024 02:25:52 +0200
Subject: [PATCH] cont. cleanup: remove superfluous std::string copies

---
 src/libmain/progress-bar.cc | 4 ++--
 src/libutil/logging.cc      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/libmain/progress-bar.cc b/src/libmain/progress-bar.cc
index e63d4f13f..22f890f7d 100644
--- a/src/libmain/progress-bar.cc
+++ b/src/libmain/progress-bar.cc
@@ -158,10 +158,10 @@ public:
     {
         auto state(state_.lock());
 
-        std::stringstream oss;
+        std::ostringstream oss;
         showErrorInfo(oss, ei, loggerSettings.showTrace.get());
 
-        log(*state, ei.level, oss.str());
+        log(*state, ei.level, toView(oss));
     }
 
     void log(State & state, Verbosity lvl, std::string_view s)
diff --git a/src/libutil/logging.cc b/src/libutil/logging.cc
index 3ef71a716..3d7371457 100644
--- a/src/libutil/logging.cc
+++ b/src/libutil/logging.cc
@@ -85,10 +85,10 @@ public:
 
     void logEI(const ErrorInfo & ei) override
     {
-        std::stringstream oss;
+        std::ostringstream oss;
         showErrorInfo(oss, ei, loggerSettings.showTrace.get());
 
-        log(ei.level, oss.str());
+        log(ei.level, toView(oss));
     }
 
     void startActivity(ActivityId act, Verbosity lvl, ActivityType type,