From bf2adf72c4fb4e04afb95ad3b2ad84c19707f246 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Wed, 24 Feb 2016 13:31:46 +0100 Subject: [PATCH] std::condition_variable_any -> std::condition_variable The latter is supposed to be more efficient. --- src/libutil/pool.hh | 2 +- src/libutil/sync.hh | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/libutil/pool.hh b/src/libutil/pool.hh index b9eb2dd1e..f291cd578 100644 --- a/src/libutil/pool.hh +++ b/src/libutil/pool.hh @@ -54,7 +54,7 @@ private: Sync state; - std::condition_variable_any wakeup; + std::condition_variable wakeup; public: diff --git a/src/libutil/sync.hh b/src/libutil/sync.hh index 3abffa7c7..c99c098ac 100644 --- a/src/libutil/sync.hh +++ b/src/libutil/sync.hh @@ -38,37 +38,37 @@ public: { private: Sync * s; + std::unique_lock lk; friend Sync; - Lock(Sync * s) : s(s) { s->mutex.lock(); } + Lock(Sync * s) : s(s), lk(s->mutex) { } public: - Lock(Lock && l) : s(l.s) { l.s = 0; } + Lock(Lock && l) : s(l.s) { abort(); } Lock(const Lock & l) = delete; - ~Lock() { if (s) s->mutex.unlock(); } + ~Lock() { } T * operator -> () { return &s->data; } T & operator * () { return s->data; } - /* FIXME: performance impact of condition_variable_any? */ - void wait(std::condition_variable_any & cv) + void wait(std::condition_variable & cv) { assert(s); - cv.wait(s->mutex); + cv.wait(lk); } template - bool wait_for(std::condition_variable_any & cv, + bool wait_for(std::condition_variable & cv, const std::chrono::duration & duration, Predicate pred) { assert(s); - return cv.wait_for(s->mutex, duration, pred); + return cv.wait_for(lk, duration, pred); } template - std::cv_status wait_until(std::condition_variable_any & cv, + std::cv_status wait_until(std::condition_variable & cv, const std::chrono::time_point & duration) { assert(s); - return cv.wait_until(s->mutex, duration); + return cv.wait_until(lk, duration); } };