NixOS/nix
NixOS/nix
1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2024-09-19 23:03:53 -04:00
Code Activity

fetchgit: Remove incomplete/unneeded ref check.

Browse source 
This check fails for tags and branches, and is made redundant by the
checks git itself will do when fetching the repo.
This commit is contained in:
Shea Levy 2017-10-16 13:25:24 -04:00
parent 8522db1641
commit cbc216911d
No known key found for this signature in database
GPG key ID: 5C0BD6957D86FE27
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/libexpr/primops/fetchgit.cc
View file

@ -19,11 +19,6 @@ Path exportGit(ref<Store> store, const std::string & uri,
throw Error("invalid Git revision '%s'", rev); throw Error("invalid Git revision '%s'", rev);
} }
// FIXME: too restrictive, but better safe than sorry.
std::regex refRegex("^[0-9a-zA-Z][0-9a-zA-Z.-]+$");
if (!std::regex_match(ref, refRegex))
throw Error("invalid Git ref '%s'", ref);
Path cacheDir = getCacheDir() + "/nix/git"; Path cacheDir = getCacheDir() + "/nix/git";
if (!pathExists(cacheDir)) { if (!pathExists(cacheDir)) {