NixOS/nix
NixOS/nix
1
0
Fork 0
mirror of https://github.com/NixOS/nix synced 2024-09-19 23:03:53 -04:00
Code Activity

Don't convert InputPaths to strings prematurely.

Browse source
This commit is contained in:
Vladimir Kryachko 2023-10-16 15:47:28 -04:00
parent b3fd7db63f
commit d6066c90f8
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/libexpr/flake/lockfile.cc
View file

@ -2,8 +2,10 @@
#include "store-api.hh"
#include "url-parts.hh"
#include <algorithm>
#include <iomanip>
#include <iterator>
#include <nlohmann/json.hpp>
namespace nix::flake {
@ -46,18 +48,18 @@ StorePath LockedNode::computeStorePath(Store & store) const
}
static std::shared_ptr<Node> doFind(const ref<Node>& root, const InputPath & path, std::vector<std::string>& visited) {
static std::shared_ptr<Node> doFind(const ref<Node>& root, const InputPath & path, std::vector<InputPath>& visited) {
auto pos = root;
auto pathS = printInputPath(path);
auto found = std::find(visited.cbegin(), visited.cend(), pathS);
auto found = std::find(visited.cbegin(), visited.cend(), path);
if(found != visited.end()) {
std::vector cycle(found, visited.cend());
cycle.push_back(pathS);
std::vector<std::string> cycle;
std::transform(found, visited.cend(), std::back_inserter(cycle), printInputPath);
cycle.push_back(printInputPath(path));
throw Error("follow cycle detected: [%s]", concatStringsSep(" -> ", cycle));
}
visited.push_back(pathS);
visited.push_back(path);
for (auto & elem : path) {
if (auto i = get(pos->inputs, elem)) {
@ -78,7 +80,7 @@ static std::shared_ptr<Node> doFind(const ref<Node>& root, const InputPath & pat
std::shared_ptr<Node> LockFile::findInput(const InputPath & path)
{
std::vector<std::string> visited;
std::vector<InputPath> visited;
return doFind(root, path, visited);
}