mirror of
https://github.com/NixOS/nix
synced 2024-09-19 10:50:24 -04:00
33ca905cdb
pararameterisation is not actually needed the way things are currently set up, and it confused me when trying to understand what the code does. all but one test sources vars-and-functions.sh, which nominally only defines variables, but in practice is always coupled with the actual initialisation. while the cleaner way of making this more legible would be to source variables and initialisation separately, this would produce a huge diff. the change requires a few small fixes to keep the tests working: - only create test home directory during initialisation that vars-and-functions.sh wrote to the file system seems not write - fix creation of the test directory due to statefulness, the test home directory was implicitly creating the test root, too. decoupling that made it apparent that this was probably not intentional, and certainly confusing. - only source vars-and-functions.sh if init.sh is not needed there is one test case that only needs a helper function but no initialisation side effects - remove some unnecessary cleanups and split parts of re-used test code there were confusing bits in how initialisation code was repurposed, which break if trying to refactor the outer layers naively... |
||
|---|---|---|
| .. | ||
| add-lower-inner.sh | ||
| add-lower.sh | ||
| bad-uris.sh | ||
| build-inner.sh | ||
| build.sh | ||
| check-post-init-inner.sh | ||
| check-post-init.sh | ||
| common.sh | ||
| delete-duplicate-inner.sh | ||
| delete-duplicate.sh | ||
| delete-refs-inner.sh | ||
| delete-refs.sh | ||
| gc-inner.sh | ||
| gc.sh | ||
| local.mk | ||
| optimise-inner.sh | ||
| optimise.sh | ||
| redundant-add-inner.sh | ||
| redundant-add.sh | ||
| remount.sh | ||
| stale-file-handle-inner.sh | ||
| stale-file-handle.sh | ||
| verify-inner.sh | ||
| verify.sh | ||