mirror of
https://github.com/NixOS/nix
synced 2024-09-20 23:28:26 -04:00
7d4cc5515c
if we defer the duplicate argument check for lambda formals we can use more
efficient data structures for the formals set, and we can get rid of the
duplication of formals names to boot. instead of a list of formals we've seen
and a set of names we'll keep a vector instead and run a sort+dupcheck step
before moving the parsed formals into a newly created lambda. this improves
performance on search and rebuild by ~1%, pure parsing gains more (about 4%).
this does reorder lambda arguments in the xml output, but the output is still
stable. this shouldn't be a problem since argument order is not semantically
important anyway.
before
nix search --no-eval-cache --offline ../nixpkgs hello
Time (mean ± σ): 8.550 s ± 0.060 s [User: 6.470 s, System: 1.664 s]
Range (min … max): 8.435 s … 8.666 s 20 runs
nix eval -f ../nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix
Time (mean ± σ): 346.7 ms ± 2.1 ms [User: 312.4 ms, System: 34.2 ms]
Range (min … max): 343.8 ms … 353.4 ms 20 runs
nix eval --raw --impure --expr 'with import <nixpkgs/nixos> {}; system'
Time (mean ± σ): 2.720 s ± 0.031 s [User: 2.415 s, System: 0.231 s]
Range (min … max): 2.662 s … 2.780 s 20 runs
after
nix search --no-eval-cache --offline ../nixpkgs hello
Time (mean ± σ): 8.462 s ± 0.063 s [User: 6.398 s, System: 1.661 s]
Range (min … max): 8.339 s … 8.542 s 20 runs
nix eval -f ../nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix
Time (mean ± σ): 329.1 ms ± 1.4 ms [User: 296.8 ms, System: 32.3 ms]
Range (min … max): 326.1 ms … 330.8 ms 20 runs
nix eval --raw --impure --expr 'with import <nixpkgs/nixos> {}; system'
Time (mean ± σ): 2.687 s ± 0.035 s [User: 2.392 s, System: 0.228 s]
Range (min … max): 2.626 s … 2.754 s 20 runs
|
||
|---|---|---|
| .. | ||
| flake | ||
| primops | ||
| attr-path.cc | ||
| attr-path.hh | ||
| attr-set.cc | ||
| attr-set.hh | ||
| common-eval-args.cc | ||
| common-eval-args.hh | ||
| eval-cache.cc | ||
| eval-cache.hh | ||
| eval-inline.hh | ||
| eval.cc | ||
| eval.hh | ||
| fetchurl.nix | ||
| function-trace.cc | ||
| function-trace.hh | ||
| get-drvs.cc | ||
| get-drvs.hh | ||
| imported-drv-to-derivation.nix | ||
| json-to-value.cc | ||
| json-to-value.hh | ||
| lexer.l | ||
| local.mk | ||
| nix-expr.pc.in | ||
| nixexpr.cc | ||
| nixexpr.hh | ||
| parser.y | ||
| primops.cc | ||
| primops.hh | ||
| symbol-table.hh | ||
| value-to-json.cc | ||
| value-to-json.hh | ||
| value-to-xml.cc | ||
| value-to-xml.hh | ||
| value.hh | ||