mirror of
https://github.com/NixOS/nix
synced 2024-09-20 11:11:03 -04:00
bc23a44c54
Already, we had classes like `BuiltPathsCommand` and `StorePathsCommand`
which provided alternative `run` virtual functions providing the
implementation with more arguments. This was a very nice and easy way to
make writing command; just fill in the virtual functions and it is
fairly clear what to do.
However, exception to this pattern were `Installable{,s}Command`. These
two classes instead just had a field where the installables would be
stored, and various side-effecting `prepare` and `load` machinery too
fill them in. Command would wish out those fields.
This isn't so clear to use.
What this commit does is make those command classes like the others,
with richer `run` functions.
Not only does this restore the pattern making commands easier to write,
it has a number of other benefits:
- `prepare` and `load` are gone entirely! One command just hands just
hands off to the next.
- `useDefaultInstallables` because `defaultInstallables`. This takes
over `prepare` for the one case that needs it, and provides enough
flexiblity to handle `nix repl`'s idiosyncratic migration.
- We can use `ref` instead of `std::shared_ptr`. The former must be
initialized (so it is like Rust's `Box` rather than `Option<Box>`,
This expresses the invariant that the installable are in fact
initialized much better.
This is possible because since we just have local variables not
fields, we can stop worrying about the not-yet-initialized case.
- Fewer lines of code! (Finally I have a large refactor that makes the
number go down not up...)
- `nix repl` is now implemented in a clearer way.
The last item deserves further mention. `nix repl` is not like the other
installable commands because instead working from once-loaded
installables, it needs to be able to load them again and again.
To properly support this, we make a new superclass
`RawInstallablesCommand`. This class has the argument parsing and
completion logic, but does *not* hand off parsed installables but
instead just the raw string arguments.
This is exactly what `nix repl` needs, and allows us to instead of
having the logic awkwardly split between `prepare`,
`useDefaultInstallables,` and `load`, have everything right next to each
other. I think this will enable future simplifications of that argument
defaulting logic, but I am saving those for a future PR --- best to keep
code motion and more complicated boolean expression rewriting separate
steps.
The "diagnostic ignored `-Woverloaded-virtual`" pragma helps because C++
doesn't like our many `run` methods. In our case, we don't mind the
shadowing it all --- it is *intentional* that the derived class only
provides a `run` method, and doesn't call any of the overridden `run`
methods.
Helps with https://github.com/NixOS/rfcs/pull/134
|
||
|---|---|---|
| .. | ||
| tests | ||
| abstract-setting-to-json.hh | ||
| ansicolor.hh | ||
| archive.cc | ||
| archive.hh | ||
| args.cc | ||
| args.hh | ||
| callback.hh | ||
| canon-path.cc | ||
| canon-path.hh | ||
| cgroup.cc | ||
| cgroup.hh | ||
| chunked-vector.hh | ||
| closure.hh | ||
| comparator.hh | ||
| compression.cc | ||
| compression.hh | ||
| compute-levels.cc | ||
| compute-levels.hh | ||
| config.cc | ||
| config.hh | ||
| error.cc | ||
| error.hh | ||
| experimental-features.cc | ||
| experimental-features.hh | ||
| filesystem.cc | ||
| finally.hh | ||
| fmt.hh | ||
| git.cc | ||
| git.hh | ||
| hash.cc | ||
| hash.hh | ||
| hilite.cc | ||
| hilite.hh | ||
| json-impls.hh | ||
| json-utils.hh | ||
| local.mk | ||
| logging.cc | ||
| logging.hh | ||
| lru-cache.hh | ||
| monitor-fd.hh | ||
| namespaces.cc | ||
| namespaces.hh | ||
| pool.hh | ||
| ref.hh | ||
| regex-combinators.hh | ||
| serialise.cc | ||
| serialise.hh | ||
| split.hh | ||
| suggestions.cc | ||
| suggestions.hh | ||
| sync.hh | ||
| tarfile.cc | ||
| tarfile.hh | ||
| thread-pool.cc | ||
| thread-pool.hh | ||
| topo-sort.hh | ||
| types.hh | ||
| url-parts.hh | ||
| url.cc | ||
| url.hh | ||
| util.cc | ||
| util.hh | ||
| xml-writer.cc | ||
| xml-writer.hh | ||