mirror of
https://github.com/NixOS/nixpkgs
synced 2024-10-19 03:47:13 -04:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
44 lines
1.4 KiB
Nix
44 lines
1.4 KiB
Nix
{ lib
|
|
, stdenv
|
|
, edk2
|
|
, llvmPackages
|
|
, util-linux
|
|
, nasm
|
|
, python3
|
|
}:
|
|
edk2.mkDerivation "ShellPkg/ShellPkg.dsc" (finalAttrs: {
|
|
pname = "edk2-uefi-shell";
|
|
inherit (edk2) version;
|
|
|
|
nativeBuildInputs = [ util-linux nasm python3 ]
|
|
++ lib.optionals stdenv.cc.isClang [ llvmPackages.bintools llvmPackages.llvm ];
|
|
strictDeps = true;
|
|
|
|
env.NIX_CFLAGS_COMPILE = toString (lib.optionals stdenv.cc.isClang [ "-fno-pic" "-Qunused-arguments" ]);
|
|
|
|
# Set explicitly to use Python 3 from nixpkgs. Otherwise, the build system will detect and try to
|
|
# use `/usr/bin/python3` on Darwin when sandboxing is disabled.
|
|
PYTHON_COMMAND = "${lib.getBin python3}/bin/python3";
|
|
|
|
# We only have a .efi file in $out which shouldn't be patched or stripped
|
|
dontPatchELF = true;
|
|
dontStrip = true;
|
|
|
|
# GUID hardcoded to match ShellPkg.dsc
|
|
installPhase = ''
|
|
runHook preInstall
|
|
install -D -m0644 Build/Shell/RELEASE*/*/Shell_EA4BB293-2D7F-4456-A681-1F22F42CD0BC.efi $out/shell.efi
|
|
runHook postInstall
|
|
'';
|
|
|
|
passthru.efi = "${finalAttrs.finalPackage}/shell.efi";
|
|
|
|
meta = {
|
|
inherit (edk2.meta) license platforms;
|
|
description = "UEFI Shell from Tianocore EFI development kit";
|
|
homepage = "https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg";
|
|
maintainers = with lib.maintainers; [ LunNova mjoerg ];
|
|
broken = stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64;
|
|
};
|
|
})
|