1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs synced 2024-10-23 11:19:04 -04:00
Nix Packages collection & NixOS
Find a file
Bjørn Forsman 3227c1d215 ncurses: fix includedir setting
${out} in configureFlags isn't expanded, so ncursesw5-config ends up
expanding ${out} at *runtime*. Here is the relevant ncursesw5-config
snippet showing how includedir gets its value at runtime.

  bindir="${exec_prefix}/bin"
  includedir="${out}/include"
  libdir="${exec_prefix}/lib"
  datadir="${prefix}/share"
  mandir="${prefix}/man"

When running in a plain shell you get this:
  $ ncursesw5-config --cflags
  -I/include/ncursesw -I/include

And when run in a nix-build shell for e.g. gpsd:
  $ ncursesw5-config --cflags
  -I/nix/store/HASH-gpsd-3.10/include/ncursesw -I/nix/store/HASH-gpsd-3.10/include

This is clearly wrong.

Q: How come this has gone undetected for years?
A: It seems few packages use ncursesw5-config to get the compiler
flags. For example, our python curses module builds its own compiler
flags.

Fix this by moving the --includedir setting to preConfigure where shell
variables are expanded.
2013-12-10 19:47:52 +01:00
doc Only show/build a package on the platforms listed in meta.platforms 2013-11-05 00:06:10 +01:00
lib gnome3.gnome-menus: fix file path, add maintainer 2013-12-07 14:04:50 +01:00
maintainers/scripts
nixos nixos/libvirtd-service: fix fail-to-start when no machines are configured 2013-12-09 19:41:44 +01:00
pkgs ncurses: fix includedir setting 2013-12-10 19:47:52 +01:00
.gitignore
.version
COPYING
default.nix