AutoMod does not initially return result of `BotCommand` #24

New issue

Closed

opened 2024-03-18 11:49:34 -04:00 by modulatingforce · 2 comments

modulatingforce commented

2024-03-18 11:49:34 -04:00

Owner

At Auto-Mod trigger from a BotCommand , the bot throws two messages likely too quickly that chat only shows the Auto mod message. Expectation is maybe that we return both messages at once or (not ideally) queue the 2nd message

Steps to Reproduce (Problem) :

In a channel where the bot is running and the bot has no special roles, have a moderator run a BotCommand that requires Mod(Channel) user role . For example getroles <user>
The bot responds, but only responds with the Auto-Mod message in chat (ISSUE)

o7 a Mod. I kneel to serve! pepeKneel

There is no message for the results of getroles <user> even if it was executed successfully . This is because twitch IRC rate limits the bot response

If you run the BotCommand again, it returns the result of the BotCommand without issues (Expected)

Expectation :

At Step (2) , the bot should respond with a concatenation of both responses

o7 a Mod. I kneel to serve! pepeKneel . Also , `<output from botcommand>`

Related Code areas

https://git.flake.sh/modulatingforce/forcebot_rs/src/branch/main/src/core/botinstance.rs#L301
https://git.flake.sh/modulatingforce/forcebot_rs/src/branch/main/src/core/identity.rs#L855

At Auto-Mod trigger from a `BotCommand` , the bot throws two messages likely too quickly that chat only shows the Auto mod message. Expectation is maybe that we return both messages at once or (not ideally) queue the 2nd message **Steps to Reproduce (Problem) :** 1. In a channel where the bot is running and the bot has no special roles, have a moderator run a `BotCommand` that requires `Mod(Channel)` user role . For example `getroles <user>` 2. The bot responds, but **_only_** responds with the Auto-Mod message in chat (ISSUE) ``` o7 a Mod. I kneel to serve! pepeKneel ``` - There is no message for the results of `getroles <user>` even if it was executed successfully . This is because twitch IRC rate limits the bot response 3. If you run the `BotCommand` again, it returns the result of the `BotCommand` without issues (Expected) **Expectation :** At Step (2) , the bot should respond with a concatenation of both responses ``` o7 a Mod. I kneel to serve! pepeKneel . Also , `<output from botcommand>` ``` **Related Code areas** https://git.flake.sh/modulatingforce/forcebot_rs/src/branch/main/src/core/botinstance.rs#L301 https://git.flake.sh/modulatingforce/forcebot_rs/src/branch/main/src/core/identity.rs#L855

modulatingforce added the

Kind/Bug

Priority

Low

labels 2024-03-18 11:49:34 -04:00

modulatingforce added a new dependency 2024-03-18 20:36:46 -04:00

#25 Enh RateLimiters with Async Sleep

modulatingforce self-assigned this 2024-03-18 22:37:49 -04:00

modulatingforce commented

2024-03-18 22:41:15 -04:00

Author

Owner

PR #25 addresses this issue through enhanced RateLimiters that use async sleep to delay a message from being sent

I'll keep this in monitoring for a few days before closing out

PR https://git.flake.sh/modulatingforce/forcebot_rs/pulls/25 addresses this issue through enhanced `RateLimiter`s that use `async sleep` to delay a message from being sent --- I'll keep this in monitoring for a few days before closing out

modulatingforce added the due date 2024-03-23

2024-03-18 22:41:23 -04:00

modulatingforce commented

2024-03-22 21:41:21 -04:00

Author

Owner

The mentioned PR fixed the issue

modulatingforce closed this issue

2024-03-22 21:41:21 -04:00