Revisit Refactor Workspaces #65

New issue

Open

opened 2024-04-05 20:30:03 -04:00 by modulatingforce · 1 comment

modulatingforce commented

2024-04-05 20:30:03 -04:00

Owner

Please revisit #12

The only cyclical obstacle would come from the following line

crate::custom::init(Arc::clone(&mgrarc)).await;

There's already an API for it - better would be to have main() call the bot's ModulesManager and load the modules from main using the API. This will remove the cyclical part, and help restructure using Workspaces

Lowish priority but earlier the better, as this may change the structure of custom modules (and require some addl guidance for custom devs)

Please revisit https://git.flake.sh/modulatingforce/forcebot_rs/pulls/12 The only cyclical obstacle would come from the following line https://git.flake.sh/modulatingforce/forcebot_rs/src/commit/e67c8582c1f3ee717faa529ba1b3af7b629dddef/src/core/botmodules.rs#L616 There's already an API for it - better would be to have `main()` call the bot's `ModulesManager` and load the modules from main using the API. This will remove the cyclical part, and help restructure using Workspaces ___ Lowish priority but earlier the better, as this may change the structure of custom modules (and require some addl guidance for custom devs)