mirror of
https://github.com/NixOS/nixpkgs
synced 2024-10-18 06:50:09 -04:00
347255a29a
When creating a PR from a branch that only adds a single commit, this heading would always jankily be left *below* the actual commit message because github simply inserts the commit message before the template. The heading also only served as a light call to action whereas the comment is rather explicit in asking the PR author to provide a proper PR description.
3.2 KiB
3.2 KiB
Things done
- Built on platform(s)
- x86_64-linux
- aarch64-linux
- x86_64-darwin
- aarch64-darwin
- For non-Linux: Is sandboxing enabled in
nix.conf? (See Nix manual)sandbox = relaxedsandbox = true
- Tested, as applicable:
- NixOS test(s) (look inside nixos/tests)
- and/or package tests
- or, for functions and "core" functionality, tests in lib/tests or pkgs/test
- made sure NixOS tests are linked to the relevant packages
- Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage - Tested basic functionality of all binary files (usually in
./result/bin/) - 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
- (Package updates) Added a release notes entry if the change is major or breaking
- (Module updates) Added a release notes entry if the change is significant
- (Module addition) Added a release notes entry if adding a new NixOS module
- Fits CONTRIBUTING.md.
Add a 👍 reaction to pull requests you find important.