It's possible for a call to `File::open()` to succeed even if reading from
that `File` isn't actually possible due to the `File` being a directory.
In such cases, `Lines` can return `Err` infinitely,
causing `filter_map()` to diverge while searching for a nonexistant `Ok`.
This is a semantic change.
`filter_map()` can filter multiple errors before returning lines again,
while `map_while()` will stop iterating entirely at the first `Err`.
However, errors are unlikely at all since the `file` argument is currently
always a preallocated temporary file for collecting `Command` output.
This merely mitigates the worst case if `lines_from_file()` is ever used
in a way where this error could occur.
A test tries to compare equality of `Vec`s, approximately `x.sort() == y.sort()`,
but `sort()` uses in-place mutation, and returns `unit`, not the input `slice`,
so the lists are never actually compared.
Sometimes most of attributes for a package are defined outside the file
that defines it. Examples are `openjdk` and `nix`.
At least `openjdk` defined `pos` attribute to guide `nix edit` to open
the right file. Let's extend `ofborg` to do the same.
Before the change (with `pos` applied to `nix_2_3`):
$ printf '[["nix_2_3"]]' > attrs.json; \
printf '["pkgs/tools/package-management/nix/default.nix"]' > paths.json; \
nix-instantiate --eval maintainers.nix --arg changedattrsjson ./attrs.json --arg changedpathsjson ./paths.json
{ }
After the change:
$ printf '[["nix_2_3"]]' > attrs.json; \
printf '["pkgs/tools/package-management/nix/default.nix"]' > paths.json; \
nix-instantiate --eval maintainers.nix --arg changedattrsjson ./attrs.json --arg changedpathsjson ./paths.json
{ flokli = <CODE>; raitobezarius = <CODE>; }
hubcaps requires a DER formatted key, but their instructions for
converting PEM to DER didn't work for me. So, we rely on rustls-pemfile
to parse the PEM key into DER bytes and hand that to hubcaps.
The current approach runs e.g. `nix-build nixos/release.nix -A tests.installer`,
which is a no-op because `tests.installer` is a set of sets of
derivations (e.g. `tests.installer.simple.x86_64-linux`).
Use `nixosTests` instead, which doesn't have this extra nesting.
last nixpkgs version that has php74 is 22.05
error: php74 has been dropped due to the lack of maintanence from upstream for future releases
there's hardly any testing possible with php so i won't mess with it
Fixes the following issue:
thread 'main' panicked at 'there is no reactor running, must be called from the context of a Tokio 1.x runtime', /build/cargo-vendor-dir/hyper-0.14.23/src/client/connect/dns.rs:121:24
