[ENH] RateLimiters to address messages sending too quickly notice #19

New issue

Closed

opened 2024-03-03 16:51:15 -05:00 by modulatingforce · 2 comments

modulatingforce commented

2024-03-03 16:51:15 -05:00

Owner

Enhance RateLimiters and current Bot Core to address the following

["Now=2024-03-03T16:32:04-0500&Pid=6848&Thr=ThreadId(7)&Seq=8"]
Notice = 'NOTICE : (#Some("modulatingforce")) Your message was not sent because you are sending messages too quickly.'
Channel = 'None'
Chatter = 'None'
Code_Module = 'Some("BotInstance > runner()")'

Steps to Reproduce :

Setup the following :

a. Bot join channel where it has no roles
b. Adjust a Listener so it responds with Every command for yourself
Spam chat yourself - for example, as broadcaster
Notice the following NOTICE is thrown in logs

To address, I think we can enhance RateLimiter and Bot Core with the following :

Considers the bot's current channel role to determine rate policy
If posting the current message would be spammy, either SKIP the message or (?) async sleep for a time to allow the message not to be spammy

Not a priority at the moment while I'm doing controlled runs of the bot ; but a must-have when ran in spammy channels

Enhance `RateLimiters` and current Bot Core to address the following ``` ["Now=2024-03-03T16:32:04-0500&Pid=6848&Thr=ThreadId(7)&Seq=8"] Notice = 'NOTICE : (#Some("modulatingforce")) Your message was not sent because you are sending messages too quickly.' Channel = 'None' Chatter = 'None' Code_Module = 'Some("BotInstance > runner()")' ``` **Steps to Reproduce :** 1. Setup the following : a. Bot join channel where it has no roles b. Adjust a Listener so it responds with Every command for yourself 2. Spam chat yourself - for example, as broadcaster 3. Notice the following NOTICE is thrown in logs --- To address, I think we can enhance `RateLimiter` and Bot Core with the following : - Considers the bot's current channel role to determine rate policy - If posting the current message would be spammy, either SKIP the message or (?) async sleep for a time to allow the message not to be spammy --- Not a priority at the moment while I'm doing controlled runs of the bot ; but a must-have when ran in spammy channels