modulatingforce/forcebot_rs
1
0
Fork 0
Code Issues 33 Pull requests 11 Projects 2 Activity

WIP: issue-routine-lock-idea2 #56

Draft
modulatingforce wants to merge 4 commits from issue-routine-lock-idea2 into issue-routine-lock
pull from: issue-routine-lock-idea2
merge into: modulatingforce:issue-routine-lock
Conversation 2 Commits 4 Files changed 10 +1124 -197
modulatingforce commented 2024-04-02 09:22:57 -04:00
Owner
Copy link

Initial Description

Possible fix for #51.

LULE my version that's way too dank

Includes enhancements to Chat for blocking calls

Branching off because changes are large, and may have introduced some problems here that need to be addressed as well

#51 (comment)

Plan of Action :

  • Implemented WAYTOODANK solution that includes enhancing Chat with an out queue that can be processed by blocking Chat.say methods
  • Will need to review other solutions first
  • Add a BotCommand that tests out Blocking Say vs Non Blocking Say
  • Unit tests?
  • Clippy & Comments cleanup
# Initial Description Possible fix for #51. LULE my version that's way too dank Includes enhancements to `Chat` for blocking calls Branching off because changes are large, and may have introduced some problems here that need to be addressed as well https://git.flake.sh/modulatingforce/forcebot_rs/pulls/51#issuecomment-1049 # Plan of Action : - [x] Implemented WAYTOODANK solution that includes enhancing `Chat` with an out queue that can be processed by blocking `Chat.say` methods - [ ] Will need to review other solutions first - [ ] Add a BotCommand that tests out Blocking Say vs Non Blocking Say - [ ] Unit tests? - [ ] Clippy & Comments cleanup
modulatingforce added 1 commit 2024-04-02 09:22:57 -04:00
modulatingforce self-assigned this 2024-04-02 09:25:40 -04:00
modulatingforce removed their assignment 2024-04-02 09:26:00 -04:00
modulatingforce self-assigned this 2024-04-02 09:26:04 -04:00
modulatingforce added this to the Forcebot Prototype 1.0 Push project 2024-04-02 09:26:06 -04:00
modulatingforce added the
Ownership
Individual Lead
 label 2024-04-02 09:28:01 -04:00
modulatingforce added the
Kind/Bug Fix
 label 2024-04-02 09:33:41 -04:00
modulatingforce reviewed 2024-04-02 10:24:17 -04:00
modulatingforce left a comment
Author
Owner
Copy link
  • #todo Adj this infinite spawning pattern
- [x] #todo Adj this infinite spawning pattern
src/core/chat.rs
@ -54,0 +142,4 @@
loop {
let r_ccc = r_cc.clone();
let chat_c = chat_ar.clone();
tokio::spawn(async move {
modulatingforce commented 2024-04-02 10:23:19 -04:00
Author
Owner
Copy link

The following and patterns like this involving a loop and inner tokio::spawn are likely why we're seeing large memory usage with this change

Lines 142 to 145 in e73bd75
loop {
let r_ccc = r_cc.clone();
let chat_c = chat_ar.clone();
tokio::spawn(async move { 

loop {
                let r_ccc = r_cc.clone();
                let chat_c = chat_ar.clone();
                tokio::spawn(async move {

Recommendation

  • if the above is really required, bound it please. For example with a for loop instead of a infinite loop
The following and patterns like this involving a `loop` and inner `tokio::spawn` are likely why we're seeing large memory usage with this change https://git.flake.sh/modulatingforce/forcebot_rs/src/commit/e73bd75de9ef38c1c0133dacea0711df63870441/src/core/chat.rs#L142-L145 ```rust loop { let r_ccc = r_cc.clone(); let chat_c = chat_ar.clone(); tokio::spawn(async move { ``` ### Recommendation - [x] if the above is really required, bound it please. For example with a `for` loop instead of a infinite `loop`
modulatingforce commented 2024-04-02 23:58:07 -04:00
Author
Owner
Copy link

The above helped the spawning and high memory usage

The above helped the spawning and high memory usage
modulatingforce marked this conversation as resolved
modulatingforce added 2 commits 2024-04-02 23:56:54 -04:00
modulatingforce commented 2024-04-03 00:02:31 -04:00
Author
Owner
Copy link

The changes introduced here are definitely more than just the specific blocking scenario, but helps in other areas that may involve blocking and sending to chat

The changes introduced here are definitely more than just the specific blocking scenario, but helps in other areas that may involve blocking and sending to chat
modulatingforce commented 2024-04-03 09:24:40 -04:00
Author
Owner
Copy link

To Update, Memory usage after a 8 hour window while I slept had the bot running just under 20mb 🤤 (it started around 18-19mb)

Jesust that scared me when it jumped to 11GB before

I will admit though, I'm a little afraid of how this will scale will more elevated chatters, because all of this is stored in memory atm . Better would be DB solution, where I offload some of the larger data sets

To Update, Memory usage after a 8 hour window while I slept had the bot running just under 20mb 🤤 (it started around 18-19mb) Jesust that scared me when it jumped to 11GB before --- I will admit though, I'm a little afraid of how this will scale will more elevated chatters, because all of this is stored in memory atm . Better would be DB solution, where I offload some of the larger data sets
modulatingforce added 1 commit 2024-04-03 21:52:56 -04:00
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue-routine-lock-idea2:issue-routine-lock-idea2
git checkout issue-routine-lock-idea2

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout issue-routine-lock
git merge --no-ff issue-routine-lock-idea2
git checkout issue-routine-lock-idea2
git rebase issue-routine-lock
git checkout issue-routine-lock
git merge --ff-only issue-routine-lock-idea2
git checkout issue-routine-lock-idea2
git rebase issue-routine-lock
git checkout issue-routine-lock
git merge --no-ff issue-routine-lock-idea2
git checkout issue-routine-lock
git merge --squash issue-routine-lock-idea2
git checkout issue-routine-lock
git merge --ff-only issue-routine-lock-idea2
git checkout issue-routine-lock
git merge issue-routine-lock-idea2
git push origin issue-routine-lock
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Automated
  
Backlog
Post_Prototype_1.0

  
Bot_Code
Core

  
Bot_Code
Custom

  
CI/CD
  
Complexity
Advanced

  
Complexity
Basic

  
Complexity
Expert

  
Complexity
Intermediate

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Bug Fix

Branches intended to address an existing Bug

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Nix
  
Ownership
Collab

  
Ownership
Collab with Leads
Collab with one or more Leads

  
Ownership
Individual Lead

  
Ownership
In-Review
Ownership may be in a review or disputed status

  
Ownership
Needs Owner > May Delegate
Tasks that may need reassignment

  
Ownership
Workshop with Leads
Workshop Tasks

  
Phase 1.0
Requirements > Drafting

  
Phase 1.0
Requirements > Researching

  
Phase 1.0
Requirements > Review & Planning

  
Phase 2.0
Design > Research & Analysis

  
Phase 3.0
Coding > Implementation

  
Phase 4.0
QA > Unit Testing & Design

  
Phase 5.0
Resolution > Completed

  
Phase 5.0
Resolution > Review for Completion

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Automated
Backlog
Post_Prototype_1.0
Bot_Code
Core
Bot_Code
Custom
CI/CD
Complexity
Advanced
Complexity
Basic
Complexity
Expert
Complexity
Intermediate
Kind/Breaking
Kind/Bug
Kind/Bug Fix
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Nix
Ownership
Collab
Ownership
Collab with Leads
Ownership
Individual Lead
Ownership
In-Review
Ownership
Needs Owner > May Delegate
Ownership
Workshop with Leads
Phase 1.0
Requirements > Drafting
Phase 1.0
Requirements > Researching
Phase 1.0
Requirements > Review & Planning
Phase 2.0
Design > Research & Analysis
Phase 3.0
Coding > Implementation
Phase 4.0
QA > Unit Testing & Design
Phase 5.0
Resolution > Completed
Phase 5.0
Resolution > Review for Completion
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Forcebot Prototype 1.0 Push
Assignees
Clear assignees
No assignees
modulatingforce
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: modulatingforce/forcebot_rs#56
No description provided.
Delete branch "issue-routine-lock-idea2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?