modulatingforce/forcebot_rs
1
0
Fork 0
Code Issues 33 Pull requests 11 Projects 2 Activity

WIP: Adjust Custom Modules Loader #68

Draft
modulatingforce wants to merge 0 commits from Refactor-custom-load into master
pull from: Refactor-custom-load
merge into: modulatingforce:master
Conversation 0 Commits - Files changed -
modulatingforce commented 2024-04-07 22:25:50 -04:00
Owner
Copy link

I know I brought this up and was a concern that if we commands all under main, that would be bulky

Line 27 in e67c858

I think an alternative is to recommend the custom developers to create a modules loader like init() and call that in main() directly on the given . There'll be a slight variation of existing logic, but mostly moving out the custom portion out of being called from core

I know I brought this up and was a concern that if we commands all under `main`, that would be bulky https://git.flake.sh/modulatingforce/forcebot_rs/src/commit/e67c8582c1f3ee717faa529ba1b3af7b629dddef/src/main.rs#L27 I think an alternative is to recommend the custom developers to create a modules loader like `init()` and call that in `main()` directly on the given . There'll be a slight variation of existing logic, but mostly moving out the custom portion out of being called from core
modulatingforce self-assigned this 2024-04-07 22:26:00 -04:00
modulatingforce added this to the Rust Learning project 2024-04-07 22:26:25 -04:00
modulatingforce modified the project from Rust Learning to Forcebot Prototype 1.0 Push 2024-04-07 22:26:42 -04:00
modulatingforce added this to the Prototype 1.0 milestone 2024-04-07 22:26:45 -04:00
Some checks failed
ci/woodpecker/pr/cargo-checks Pipeline was successful
Details
ci/woodpecker/cron/flake-update Pipeline failed
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Refactor-custom-load:Refactor-custom-load
git checkout Refactor-custom-load
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Automated
  
Backlog
Post_Prototype_1.0

  
Bot_Code
Core

  
Bot_Code
Custom

  
CI/CD
  
Complexity
Advanced

  
Complexity
Basic

  
Complexity
Expert

  
Complexity
Intermediate

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Bug Fix

Branches intended to address an existing Bug

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Nix
  
Ownership
Collab

  
Ownership
Collab with Leads
Collab with one or more Leads

  
Ownership
Individual Lead

  
Ownership
In-Review
Ownership may be in a review or disputed status

  
Ownership
Needs Owner > May Delegate
Tasks that may need reassignment

  
Ownership
Workshop with Leads
Workshop Tasks

  
Phase 1.0
Requirements > Drafting

  
Phase 1.0
Requirements > Researching

  
Phase 1.0
Requirements > Review & Planning

  
Phase 2.0
Design > Research & Analysis

  
Phase 3.0
Coding > Implementation

  
Phase 4.0
QA > Unit Testing & Design

  
Phase 5.0
Resolution > Completed

  
Phase 5.0
Resolution > Review for Completion

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Automated
Backlog
Post_Prototype_1.0
Bot_Code
Core
Bot_Code
Custom
CI/CD
Complexity
Advanced
Complexity
Basic
Complexity
Expert
Complexity
Intermediate
Kind/Breaking
Kind/Bug
Kind/Bug Fix
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Nix
Ownership
Collab
Ownership
Collab with Leads
Ownership
Individual Lead
Ownership
In-Review
Ownership
Needs Owner > May Delegate
Ownership
Workshop with Leads
Phase 1.0
Requirements > Drafting
Phase 1.0
Requirements > Researching
Phase 1.0
Requirements > Review & Planning
Phase 2.0
Design > Research & Analysis
Phase 3.0
Coding > Implementation
Phase 4.0
QA > Unit Testing & Design
Phase 5.0
Resolution > Completed
Phase 5.0
Resolution > Review for Completion
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Prototype 1.0
Projects
Clear projects
No items
No project
Forcebot Prototype 1.0 Push
Assignees
Clear assignees
No assignees
modulatingforce
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: modulatingforce/forcebot_rs#68
No description provided.
Delete branch "Refactor-custom-load"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?