modulatingforce/forcebot_rs
1
0
Fork 0
Code Issues 33 Pull requests 11 Projects 2 Activity

Cucked alt for promote #75

Merged
modulatingforce merged 4 commits from cucked into master 2024-04-09 13:39:35 -04:00
Conversation 1 Commits 4 Files changed 1 +97 -20
modulatingforce commented 2024-04-09 09:03:44 -04:00
Owner
Copy link

Addressing #70

Recommended Implementation details

  1. Check if the Given Argument is an Existing Chatter
  1. If the call was the alt cucked specifically (rather than regular promote) ,
  • Respond first with uhhh , pause for 1s , then go through promotion process as normal

Plan of Action

  • Code
  • Unit Tests?
  • Live Tests
  • adj getroles command the self involve too
  • clippy & fmt cleanup
Addressing https://git.flake.sh/modulatingforce/forcebot_rs/issues/70 # Recommended Implementation details 1. Check if the Given Argument is an Existing Chatter - [x] use https://docs.rs/twitch-irc/5.0.1/twitch_irc/validate/fn.validate_login.html - [x] If the argument is not known login, target the invoker - [x] ~~ideally, some helper fn as there are other bot commands that may target the invoker~~ - Not required 2. If the call was the alt `cucked` specifically (rather than regular `promote`) , - [x] Respond first with `uhhh` , pause for 1s , then go through promotion process as normal --- # Plan of Action - [x] Code - [x] ~~Unit Tests?~~ - [x] Live Tests - [x] adj getroles command the self involve too - [x] clippy ~~& fmt~~ cleanup
modulatingforce added this to the Prototype 1.0 milestone 2024-04-09 09:03:44 -04:00
modulatingforce self-assigned this 2024-04-09 09:03:44 -04:00
modulatingforce added this to the Forcebot Prototype 1.0 Push project 2024-04-09 09:03:45 -04:00
modulatingforce added the
Kind/Enhancement
Complexity
Basic
 labels 2024-04-09 09:04:26 -04:00
modulatingforce changed title from Cucked alt for promote to WIP: Cucked alt for promote 2024-04-09 09:05:41 -04:00
modulatingforce added 1 commit 2024-04-09 10:00:08 -04:00
modulatingforce requested review from HaruYuumei 2024-04-09 10:00:30 -04:00
modulatingforce reviewed 2024-04-09 10:04:45 -04:00
modulatingforce left a comment
Author
Owner
Copy link

Hi @HaruYuumei

Can you test this branch at some point? Let me know if you have questions

I don't think there's anything to add? (no need to add test commands) . Just making sure if you have issues or questions

My live tests seem to be fine at the moment

Thanks!

Hi @HaruYuumei Can you test this branch at some point? Let me know if you have questions I don't think there's anything to add? (no need to add test commands) . Just making sure if you have issues or questions My live tests seem to be fine at the moment Thanks!
src/core/identity.rs Outdated
@ -225,0 +264,4 @@
params.clone(),
).await;
sleep(Duration::from_secs_f64(2.0)).await;
modulatingforce commented 2024-04-09 10:03:27 -04:00
Author
Owner
Copy link

promote BotCommand now has logic to handle the alt cucked or cuck

  1. If a BotAdmin sends the cucked alt command specifically (and not promote), and the targetuser is not a valid user , the promote command will target the BotAdmin

  2. The Bot will go through and funny awkward message workflow in chat before promoting the target user

`promote` `BotCommand` now has logic to handle the alt `cucked` or `cuck` 1. If a `BotAdmin` sends the `cucked` alt command specifically (and not `promote`), and the targetuser is not a valid user , the `promote` command will target the `BotAdmin` 2. The Bot will go through and funny awkward message workflow in chat before promoting the target user
modulatingforce commented 2024-04-09 11:43:17 -04:00
Author
Owner
Copy link

Haru tested looks good

Haru tested looks good
modulatingforce marked this conversation as resolved
modulatingforce added 2 commits 2024-04-09 12:36:51 -04:00
modulatingforce changed title from WIP: Cucked alt for promote to Cucked alt for promote 2024-04-09 12:37:42 -04:00
modulatingforce changed title from Cucked alt for promote to WIP: Cucked alt for promote 2024-04-09 12:42:00 -04:00
modulatingforce commented 2024-04-09 12:44:57 -04:00
Author
Owner
Copy link

@notohh Aware something's not working - the CI/CD here didn't trigger , even when I removed WIP. Normally, I should see something per push?

I don't think I see anything wrong. Can you check this?

@notohh Aware something's not working - the CI/CD here didn't trigger , even when I removed WIP. Normally, I should see something per push? I don't think I see anything wrong. Can you check this?
modulatingforce added 1 commit 2024-04-09 13:37:23 -04:00
Merge branch 'master' into cucked
All checks were successful
ci/woodpecker/pr/cargo-checks Pipeline was successful
Details
764a912122
modulatingforce changed title from WIP: Cucked alt for promote to Cucked alt for promote 2024-04-09 13:39:14 -04:00
modulatingforce merged commit 018e8306e4 into master 2024-04-09 13:39:35 -04:00
modulatingforce deleted branch cucked 2024-04-09 13:39:35 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
HaruYuumei
Labels
Clear labels   
Automated
  
Backlog
Post_Prototype_1.0

  
Bot_Code
Core

  
Bot_Code
Custom

  
CI/CD
  
Complexity
Advanced

  
Complexity
Basic

  
Complexity
Expert

  
Complexity
Intermediate

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Bug Fix

Branches intended to address an existing Bug

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Nix
  
Ownership
Collab

  
Ownership
Collab with Leads
Collab with one or more Leads

  
Ownership
Individual Lead

  
Ownership
In-Review
Ownership may be in a review or disputed status

  
Ownership
Needs Owner > May Delegate
Tasks that may need reassignment

  
Ownership
Workshop with Leads
Workshop Tasks

  
Phase 1.0
Requirements > Drafting

  
Phase 1.0
Requirements > Researching

  
Phase 1.0
Requirements > Review & Planning

  
Phase 2.0
Design > Research & Analysis

  
Phase 3.0
Coding > Implementation

  
Phase 4.0
QA > Unit Testing & Design

  
Phase 5.0
Resolution > Completed

  
Phase 5.0
Resolution > Review for Completion

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Automated
Backlog
Post_Prototype_1.0
Bot_Code
Core
Bot_Code
Custom
CI/CD
Complexity
Advanced
Complexity
Basic
Complexity
Expert
Complexity
Intermediate
Kind/Breaking
Kind/Bug
Kind/Bug Fix
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Nix
Ownership
Collab
Ownership
Collab with Leads
Ownership
Individual Lead
Ownership
In-Review
Ownership
Needs Owner > May Delegate
Ownership
Workshop with Leads
Phase 1.0
Requirements > Drafting
Phase 1.0
Requirements > Researching
Phase 1.0
Requirements > Review & Planning
Phase 2.0
Design > Research & Analysis
Phase 3.0
Coding > Implementation
Phase 4.0
QA > Unit Testing & Design
Phase 5.0
Resolution > Completed
Phase 5.0
Resolution > Review for Completion
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Prototype 1.0
Projects
Clear projects
No items
No project
Forcebot Prototype 1.0 Push
Assignees
Clear assignees
No assignees
modulatingforce
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: modulatingforce/forcebot_rs#75
No description provided.
Delete branch "cucked"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?