notohh/rustlings
notohh/rustlings
1
0
Fork 0
mirror of https://github.com/notohh/rustlings.git synced 2024-11-25 23:04:17 -05:00
Code Issues Projects Releases Packages Wiki Activity

doc: update contributing

Browse source
This commit is contained in:
mokou 2022-07-15 12:57:54 +02:00
parent b609f0431c
commit 0784f54141
1 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
CONTRIBUTING.md
View file

@ -21,7 +21,7 @@ _implement a new feature! ➡️ [open an Issue to discuss it first, then a Pull
`rustlings` is basically a glorified `rustc` wrapper. Therefore the source code `rustlings` is basically a glorified `rustc` wrapper. Therefore the source code
isn't really that complicated since the bulk of the work is done by `rustc`. isn't really that complicated since the bulk of the work is done by `rustc`.
`src/main.rs` contains a simple `clap` CLI that loads from `src/verify.rs` and `src/run.rs`. `src/main.rs` contains a simple `argh` CLI that connects to most of the other source files.
<a name="addex"></a> <a name="addex"></a>
### Adding an exercise ### Adding an exercise
@ -29,7 +29,7 @@ isn't really that complicated since the bulk of the work is done by `rustc`.
The first step is to add the exercise! Name the file `exercises/yourTopic/yourTopicN.rs`, make sure to The first step is to add the exercise! Name the file `exercises/yourTopic/yourTopicN.rs`, make sure to
put in some helpful links, and link to sections of the book in `exercises/yourTopic/README.md`. put in some helpful links, and link to sections of the book in `exercises/yourTopic/README.md`.
Next make sure it runs with `rustlings`. The exercise metadata is stored in `info.toml`, under the `exercises` array. The order of the `exercises` array determines the order the exercises are run by `rustlings verify`. Next make sure it runs with `rustlings`. The exercise metadata is stored in `info.toml`, under the `exercises` array. The order of the `exercises` array determines the order the exercises are run by `rustlings verify` and `rustlings watch`.
Add the metadata for your exercise in the correct order in the `exercises` array. If you are unsure of the correct ordering, add it at the bottom and ask in your pull request. The exercise metadata should contain the following: Add the metadata for your exercise in the correct order in the `exercises` array. If you are unsure of the correct ordering, add it at the bottom and ask in your pull request. The exercise metadata should contain the following:
```diff ```diff
@ -43,7 +43,7 @@ Add the metadata for your exercise in the correct order in the `exercises` array
... ...
``` ```
The `mode` attribute decides whether Rustlings will only compile your exercise, or compile and test it. If you have tests to verify in your exercise, choose `test`, otherwise `compile`. The `mode` attribute decides whether Rustlings will only compile your exercise, or compile and test it. If you have tests to verify in your exercise, choose `test`, otherwise `compile`. If you're working on a Clippy exercise, use `mode = "clippy"`.
That's all! Feel free to put up a pull request. That's all! Feel free to put up a pull request.
@ -67,19 +67,19 @@ changes. There's a couple of things to watch out for:
#### Write correct commit messages #### Write correct commit messages
We follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0-beta.4/) We follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0-beta.4/)
specification, because it makes it easier to generate changelogs automatically. specification.
This means that you have to format your commit messages in a specific way. Say This means that you have to format your commit messages in a specific way. Say
you're working on adding a new exercise called `foobar1.rs`. You could write you're working on adding a new exercise called `foobar1.rs`. You could write
the following commit message: the following commit message:
``` ```
feat: Add foobar1.rs exercise feat: add foobar1.rs exercise
``` ```
If you're just fixing a bug, please use the `fix` type: If you're just fixing a bug, please use the `fix` type:
``` ```
fix(verify): Make sure verify doesn't self-destruct fix(verify): make sure verify doesn't self-destruct
``` ```
The scope within the brackets is optional, but should be any of these: The scope within the brackets is optional, but should be any of these:
@ -96,7 +96,7 @@ When the commit also happens to close an existing issue, link it in the message
body: body:
``` ```
fix: Update foobar fix: update foobar
closes #101029908 closes #101029908
``` ```
@ -104,13 +104,13 @@ closes #101029908
If you're doing simple changes, like updating a book link, use `chore`: If you're doing simple changes, like updating a book link, use `chore`:
``` ```
chore: Update exercise1.rs book link chore: update exercise1.rs book link
``` ```
If you're updating documentation, use `docs`: If you're updating documentation, use `docs`:
``` ```
docs: Add more information to Readme docs: add more information to Readme
``` ```
If, and only if, you're absolutely sure you want to make a breaking change If, and only if, you're absolutely sure you want to make a breaking change
@ -118,7 +118,7 @@ If, and only if, you're absolutely sure you want to make a breaking change
explain the breaking change in the message body: explain the breaking change in the message body:
``` ```
fix!: Completely change verification fix!: completely change verification
BREAKING CHANGE: This has to be done because lorem ipsum dolor BREAKING CHANGE: This has to be done because lorem ipsum dolor
``` ```
@ -126,6 +126,5 @@ BREAKING CHANGE: This has to be done because lorem ipsum dolor
#### Pull Request Workflow #### Pull Request Workflow
Once you open a Pull Request, it may be reviewed or labeled (or both) until Once you open a Pull Request, it may be reviewed or labeled (or both) until
the maintainers accept your change. Then, [bors](https://github.com/bors) will the maintainers accept your change. Please be patient, it may take some time
run the test suite with your changes and if it's successful, automatically for this to happen!
merge it in!