Commit graph

2224 commits

Author SHA1 Message Date
diannasoreil
969384c258
Merge pull request #890 from frvannes16/fix/888-std-floats
fix(clippy1): Trigger approx_constant lint rule instead of downgraded float_cmp.
2021-12-16 14:10:58 +01:00
Franklin van Nes
f2650de369 fix(clippy1): Updated code to test correctness clippy lint with approx_constant lint rule
closes #888
2021-12-15 11:46:27 -05:00
diannasoreil
acaee79994
Merge pull request #889 from rust-lang/all-contributors/add-alirezaghey
docs: add alirezaghey as a contributor for content
2021-12-15 10:44:48 +01:00
allcontributors[bot]
527a5b1182
docs: update .all-contributorsrc [skip ci] 2021-12-15 09:44:39 +00:00
allcontributors[bot]
72b2c9f54f
docs: update README.md [skip ci] 2021-12-15 09:44:38 +00:00
alirezaghey
8ef4869b26
fix(functions5): Remove wrong new line and small English improvements (#885) 2021-12-15 10:44:21 +01:00
diannasoreil
dba759e1c6
Merge pull request #872 from rust-lang/all-contributors/add-MpdWalsh
docs: add MpdWalsh as a contributor for code
2021-10-31 17:25:43 +01:00
allcontributors[bot]
cb661896a2
docs: update .all-contributorsrc [skip ci] 2021-10-31 16:25:36 +00:00
allcontributors[bot]
e08b6cf3ef
docs: update README.md [skip ci] 2021-10-31 16:25:35 +00:00
diannasoreil
e2fa512e86
Merge pull request #871 from MpdWalsh/main
fix(structs3.rs): assigned value to cents_per_gram in test
2021-10-31 17:25:18 +01:00
Michael Walsh
d1ee2daf14 fix(structs3.rs): assigned value to cents_per_gram in test
Intended to simplify the lesson by removing the need to figure out what the value is meant to be based on the tests.

Previous commits (9ca08b8f2b and 114b54cbdb (diff-ce1c232ff0ddaff909351bb84cb5bff423b5b9e04f21fd4db7ffe443e598e174)) removed the mathematical complexity, and I feel this addition is a needed change to further streamline the exercise.
2021-10-30 16:55:58 -06:00
ana
359f81dd0b chore: upgrade edition to 2021 2021-10-29 14:27:48 +02:00
diannasoriel
5e5271247a
Merge pull request #866 from rust-lang/all-contributors/add-xuesongbj
docs: add xuesongbj as a contributor for content
2021-10-18 13:57:42 +02:00
allcontributors[bot]
71da9068e7
docs: update .all-contributorsrc [skip ci] 2021-10-18 11:57:34 +00:00
allcontributors[bot]
b24b295d88
docs: update README.md [skip ci] 2021-10-18 11:57:33 +00:00
xuesong
1663a16ead
fix(traits1): rename test functions to snake case (#854)
Co-authored-by: zhangshaozhi <zhangshaozhi@ZhangshaozhideMacBook-Pro.local>
2021-10-18 13:57:12 +02:00
diannasoriel
af91eb508a
Merge pull request #860 from rlch/spelling-mistakes
fix: few spelling mistakes
2021-10-02 23:09:52 +02:00
rlch
1c0fe3cbcc fix: few spelling mistakes 2021-10-02 23:59:23 +10:00
diannasoriel
ed7fe883b9
Merge pull request #858 from rust-lang/all-contributors/add-fredr
docs: add fredr as a contributor for content
2021-09-30 10:19:33 +02:00
allcontributors[bot]
ae54c17b6a
docs: update .all-contributorsrc [skip ci] 2021-09-30 08:18:53 +00:00
allcontributors[bot]
574bbffe0b
docs: update README.md [skip ci] 2021-09-30 08:18:52 +00:00
Fredrik Enestad
46c28d5cef
fix(move_semantics5): correct typo (#857) 2021-09-30 10:18:36 +02:00
diannasoriel
ad338ee789
Merge pull request #853 from rust-lang/all-contributors/add-EmisonLu
docs: add EmisonLu as a contributor for content
2021-09-27 10:03:57 +02:00
allcontributors[bot]
e3cfaa246d
docs: update .all-contributorsrc [skip ci] 2021-09-27 08:03:47 +00:00
allcontributors[bot]
fed4fe78bb
docs: update README.md [skip ci] 2021-09-27 08:03:46 +00:00
Zhenghao Lu
bf33829da2
fix(structs3): remove redundant 'return' (#852) 2021-09-27 10:03:28 +02:00
ana
d57c183028 release: 4.6.0 2021-09-25 11:23:05 +02:00
diannasoriel
c2ed98deb3
Merge pull request #781 from tlyu/advanced-errs
feature: advanced errors
2021-09-25 11:18:55 +02:00
Taylor Yu
abd6b70c72 feat: add advanced_errs2
New exercise to demonstrate traits that make it easier for other code
to consume our custom error types.
2021-09-25 11:18:23 +02:00
Taylor Yu
882d535ba8 feat: add advanced_errs1
New section and exercise to demonstrate the `From` trait for errors
and its usefulness with the `?` operator.
2021-09-25 11:18:21 +02:00
diannasoriel
0de45ccdb7
Merge pull request #851 from rust-lang/all-contributors/add-frogtd
docs: add frogtd as a contributor for content
2021-09-25 10:53:13 +02:00
allcontributors[bot]
ab5ecbee7a
docs: update .all-contributorsrc [skip ci] 2021-09-25 08:53:05 +00:00
allcontributors[bot]
e106d7a4f4
docs: update README.md [skip ci] 2021-09-25 08:53:04 +00:00
frogtd
d75759e829
fix(move_semantics5): change &mut *y to &mut x (#814)
Instead of having to explain why 
```rs
let mut x = 100; 
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;
```
and 
```rs
let mut x = 100; 
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;
```
are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.

Example of someone being confused by this:
<https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040>
2021-09-25 10:52:18 +02:00
diannasoriel
db9d7a907d
Merge pull request #850 from rust-lang/all-contributors/add-abusch
docs: add abusch as a contributor for code
2021-09-25 10:48:04 +02:00
allcontributors[bot]
a1b9c50f36
docs: update .all-contributorsrc [skip ci] 2021-09-25 08:47:56 +00:00
allcontributors[bot]
c4b59aa593
docs: update README.md [skip ci] 2021-09-25 08:47:55 +00:00
diannasoriel
4a18bdeefe
Merge pull request #843 from abusch/quit_command
feat: Add "quit" command to `rustlings watch`
2021-09-25 10:47:36 +02:00
Antoine Busch
1caef0b434 feat: Add "quit" command to rustlings watch
closes: #842
2021-09-24 23:55:55 +10:00
diannasoriel
ae56cba9c8
Merge pull request #846 from rust-lang/feat/add-more-watch-commands
feat: add more watch commands
2021-09-24 13:05:04 +02:00
ana
3352b5a4d3 chore: improve println! usage 2021-09-24 13:04:30 +02:00
diannasoriel
24762434ff
Merge pull request #849 from rust-lang/all-contributors/add-Millione
docs: add Millione as a contributor for content
2021-09-21 11:50:41 +02:00
allcontributors[bot]
e9c0ca6be2
docs: update .all-contributorsrc [skip ci] 2021-09-21 09:50:32 +00:00
allcontributors[bot]
9ef63c0b9b
docs: update README.md [skip ci] 2021-09-21 09:50:31 +00:00
LIU JIE
06d5c0973a
fix(cli): typo in exercise.rs (#848) 2021-09-21 11:50:15 +02:00
diannasoriel
8d82856233
Merge pull request #847 from rust-lang/all-contributors/add-Weilet
docs: add Weilet as a contributor for content
2021-09-21 10:44:15 +02:00
allcontributors[bot]
9ddd4ca33a
docs: update .all-contributorsrc [skip ci] 2021-09-21 08:44:04 +00:00
allcontributors[bot]
fe726f5bca
docs: update README.md [skip ci] 2021-09-21 08:44:03 +00:00
Weilet
0a11bad714
feat(quiz1): add default function name in comment (#838) 2021-09-21 10:43:44 +02:00
ana
a7dc080b95 feat: add more watch commands
Includes:
- quit, to quit the shell instead of having to press Cmd/Ctrl-C or Cmd/Ctrl-D
- help, to display an overview of all the commands available in watch mode.

Closes #842.
2021-09-21 10:36:11 +02:00